Skip to content

chore: allow builds to use specified architecture #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2024
Merged

chore: allow builds to use specified architecture #413

merged 1 commit into from
Jan 26, 2024

Conversation

duncanista
Copy link
Contributor

What does this PR do?

Allows the build layers script to use architecture if specified.

Motivation

Currently it builds for both runtimes if not specified, its slowing down GitLab jobs.

Testing Guidelines

n/a

Additional Notes

Usage is

PYTHON_VERSION=3.10 ARCH=amd64 ./scripts/build_layers

Will build 3.10 on amd64.
Any other value besides arm64|amd64 will fail.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@duncanista duncanista requested a review from a team as a code owner January 26, 2024 20:57
astuyve
astuyve approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved on the understanding the $ARCH var is consistent across repos?

@duncanista
Copy link
Contributor Author

approved on the understanding the $ARCH var is consistent across repos?

@astuyve this hasn't been done in any other place AFAIK

@astuyve
Copy link
Contributor

astuyve commented Jan 26, 2024

Okay that's fine then 👍🏻

@duncanista duncanista merged commit 459d11d into main Jan 26, 2024
@duncanista duncanista deleted the jordan.gonzalez/allow-builds-per-arch branch January 26, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astuyve astuyve astuyve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duncanista @astuyve